Repository navigation
feat(go): one builder binary that answers as the Python does - #27
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
set -e aborted the version read when the manifest was missing, so the shim exited 2 with no message. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ToLower missed Python casefold mappings such as final sigma and ligatures, so a send Python logged was not a duplicate for Go. A table generated from str.casefold replaces it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone 1 of the Go port (spec:
docs/superpowers/specs/2026-10-25-go-port-and-cleanup-design.md, plan:docs/superpowers/plans/2026-10-26-go-port-m1.md).One
builderbinary now does what the Python does:hook,ledger,reach,security,budgetandmcp-merge, plusgo run ./cmd/support-table. The committed shimbin/builderruns the binary pinned to the plugin version, or exits 3 with the install line. The Python stays and still runs everything; milestone 2 switches the callers to the shim and deletes it.tests/test_parity.shruns the Python and the Go on the same inputs, 27 cases: text compared byte for byte, JSON afterjq -S, plus ledger and reach files written in one language and read in the other.scripts/validate.shgains a→ gostep: gofmt, go vet, go test, the shim test and parity. CI sets up Go fromgo.mod.Calls made on the way (each with its reason in the commits):
config.tomlreads as empty, as in the Python.builder budgetwith a bad number prints the usage and exits 2; the Python crashed with a traceback.str.casefold.Deferred minors (edge cases where the Go differs from the Python; none on a path a skill takes today): mcp-merge loses big-int precision and key order; non-UTF-8
reach.jsonis accepted; U+0085 in a logged text; a mapping block with no closing marker;+Infvsinf;cli.Reprcorner cases; one OS-reason wording; greedy version read on a one-line manifest; notifier WaitDelay; no kill test.🤖 Generated with Claude Code