fix: quote load paths, imports, and transpile inputs - #2128
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
Contributor
Author
3 tasks
alistairewj
requested changes
Jul 25, 2026
alistairewj
left a comment
Member
There was a problem hiding this comment.
the changes are scattered and not very cohesive but with some cleaning up we can merge
Chessing234
force-pushed
the
fix/load-path-infra
branch
from
July 29, 2026 15:28
a093a10 to
0d36c15
Compare
Contributor
Author
|
Addressed review feedback in 270b6d3:
|
This was referenced Jul 31, 2026
Contributor
Author
Chessing234
force-pushed
the
fix/load-path-infra
branch
from
August 5, 2026 10:34
427d504 to
3015382
Compare
Contributor
|
@alistairewj Ready for another look. Your July 25 review asks are addressed as follows:
This PR now keeps only the remaining load-path / transpile / duckdb import / validate_demo infra. Happy to cut anything else that still feels out of scope. |
Contributor
Author
Contributor
Author
|
@alistairewj resolved the review threads — ready for another look when you have time. |
Contributor
Author
|
@alistairewj re-review please when you get a chance — pushed after your review to address each point:
kept this PR scoped to load-path / transpile / import infra only. |
Rebased onto main and squashed to the net change after several rounds of trimming; the sqlfluff and sqlite hunks are in MIT-LCP#2148 / MIT-LCP#2149. Covers duckdb load-path quoting for mimic-iii, -ed and -note, the postgres datadir/user quoting and concepts build order, transpile UTF-8 handling with its test, and the validate_demo table lists. The mimic-iv duckdb hunk is dropped: main replaced mimic-iv/buildmimic/duckdb/import_duckdb.sh with build_mimic.sh in MIT-LCP#1757, so that file no longer exists.
Chessing234
force-pushed
the
fix/load-path-infra
branch
from
August 23, 2026 16:13
3d189fe to
1ced609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased onto current main and squashed to the net change after the earlier rounds of trimming.
validate_demo.sqlScope changes since this was opened, so the old title no longer described the diff:
.csv/.csv.gzdiscovery, its unit tests and CI moved to fix(mimic-iii): load plain CSV in sqlite import.py (prefer .csv.gz) #2149mimic-iv/buildmimic/duckdb/import_duckdb.shwithbuild_mimic.shin Docker mimic iv postgres #1757, so that file no longer existsThis branch touches no GitHub Actions workflow.
Worth flagging separately: main's replacement
mimic-iv/buildmimic/duckdb/build_mimic.sh:116interpolates the path straight intoCOPY ${table} FROM '${file}', so it carries the same unescaped-path problem the dropped hunk fixed. I have not folded that in here — happy to open it on its own if useful.Test plan
pytest tests/test_transpile.py