Conversation
Why are these changes being introduced: * Our logs were inclidng the full graphql query (twice) * This was excessively long and taking up a lot of space in our logs Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-677 How does this address that need: * Suppresses logging the graphql query and extracts and logs just the search term Document any side effects to this change: * When we move to structured logging, we'll want to include the search term as a field and not a separate logline. That is out of scope of this work but will come soon as we move from Logz to CloudWatch
❌ 1 blocking issue (1 total)
|
matt-bernhardt
approved these changes
Aug 20, 2026
matt-bernhardt
left a comment
Member
There was a problem hiding this comment.
This seems pretty straightforward. I see the different log messages between staging and this review app, which is an improvement. I agree that we'll need to tweak this again when we do more with logging, but for now this is what's needed.
![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Document any side effects to this change:
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO