-
Notifications
You must be signed in to change notification settings - Fork 6
Fix outdated syntax #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+60
−4
Merged
Fix outdated syntax #985
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| require 'test_helper' | ||
|
|
||
| class RackAttackTest < ActiveSupport::TestCase | ||
| test 'throttled_responder accepts Rack::Attack::Request and returns 429 response' do | ||
| env = { | ||
| 'rack.attack.match_data' => { | ||
| limit: 100, | ||
| count: 101, | ||
| period: 60, | ||
| epoch_time: 1_700_000_000 | ||
| } | ||
| } | ||
|
|
||
| request = Rack::Attack::Request.new(env) | ||
|
|
||
| status, headers, body = Rack::Attack.throttled_responder.call(request) | ||
|
|
||
| assert_equal 429, status | ||
| assert_equal 'application/json', headers['Content-Type'] | ||
| assert_equal '100', headers['RateLimit-Limit'] | ||
| assert_equal '0', headers['RateLimit-Remaining'] | ||
| assert_equal '1700000040', headers['RateLimit-Reset'] | ||
|
|
||
| parsed_body = JSON.parse(body.first) | ||
| assert_equal '100', parsed_body['request_limit'] | ||
| assert_equal '101', parsed_body['request_count'] | ||
| assert_equal true, parsed_body.key?('error') | ||
| end | ||
|
|
||
| test 'safelist allows authenticated request with valid bearer token and user' do | ||
| user = users(:yo) | ||
| request = Rack::Attack::Request.new('HTTP_AUTHORIZATION' => 'Bearer valid.token') | ||
|
|
||
| JwtWrapper.stubs(:decode).with('valid.token').returns({ 'user_id' => user.id }) | ||
|
|
||
| assert_equal true, Rack::Attack.configuration.safelisted?(request) | ||
| end | ||
|
|
||
| test 'safelist rejects invalid bearer token' do | ||
| request = Rack::Attack::Request.new('HTTP_AUTHORIZATION' => 'Bearer invalid.token') | ||
|
|
||
| JwtWrapper.stubs(:decode).with('invalid.token').raises(JWT::DecodeError) | ||
|
|
||
| assert_equal false, Rack::Attack.configuration.safelisted?(request) | ||
| end | ||
|
|
||
| test 'safelist rejects non-bearer authorization strategy' do | ||
| request = Rack::Attack::Request.new('HTTP_AUTHORIZATION' => 'Basic abc123') | ||
|
|
||
| assert_equal false, Rack::Attack.configuration.safelisted?(request) | ||
| end | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a world where we extract lines 85-88 to some helper method to make the assembly of this value more separate / testable? I really like the approach of calculating
resetseparately from the invocation of it down on line 94, but working out the logic of how we got there took me a minute.