fix(deps): raise the brace-expansion override floor to 5.0.9 - #242
Merged
Conversation
GHSA-rgw5-rvv9-x895 is the third brace-expansion DoS advisory: unbounded intermediate arrays, which bypasses the CVE-2026-14257 mitigation. It is fixed in 5.0.9 and flags everything below that, including the 5.0.8 the existing override pinned to. The override was written as a range around the previous report (>=3.0.0 <5.0.8), so it read as resolved while still allowing a flagged version to install. Rewrite it as a plain floor against the newest advisory instead, which is the shape that survives the next round. The tree had both 5.0.8 and 5.0.9 installed, pulled in by minimatch 10.2.5 and 10.2.6. The lockfile change is otherwise removals: 5.0.9 is now the single copy. Same major, so no repeat of the callable-export break that made the jump to 5.x awkward. Verified anyway, since the consumers sit under exceljs at runtime: an xlsx write/read roundtrip returns brace literals and umlauts unchanged.
Musiker15
force-pushed
the
fix/brace-expansion-509
branch
from
August 17, 2026 21:19
fee57dc to
46c238a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the open high alert GHSA-rgw5-rvv9-x895 (brace-expansion DoS via unbounded intermediate arrays, bypassing the CVE-2026-14257 mitigation, first patched in 5.0.9).
What was wrong with the existing override
It was written as a range around the previous advisory, so it looked settled while the new one flags everything below 5.0.9, 5.0.8 included. The tree actually carried two copies, 5.0.8 and 5.0.9, pulled in by minimatch 10.2.5 and 10.2.6 respectively.
Rewriting it as a plain floor against the newest advisory collapses that to a single 5.0.9. The rest of the lockfile diff is removals.
The comment above it now spells out why the bound has that shape, since this is the third time this package has come around and the second time the floor was the thing that quietly aged out.
Verification
Same major, so none of the callable-export trouble that made the jump to 5.x awkward. Checked anyway, because these consumers sit under exceljs at runtime rather than in tooling: an xlsx write and read-back returns brace literals and umlauts unchanged (
["Müller-Lüdenscheidt","Auswahl {a,b} mit Umlauten öäü"], 6526 bytes).lint,typecheckandtestpass locally.