Repository navigation
fix(keys-sync): report GPG execution failures - #12
Draft
MakerFlyFly wants to merge 2 commits into
Draft
MakerFlyFly wants to merge 2 commits into
MakerFlyFly wants to merge 2 commits into
Conversation
Check import and listing return codes before assessing a fetched public key. Preserve missing-key results only for a confirmed no-data import followed by a successful empty listing. Include the GPG stage and diagnostics in the existing error response, and cover both operational failures and the compatible no-data cases. Generated-by: OpenAI Codex (GPT-6)
Read regular key files completely before considering an empty input, and import the same bytes through stdin. Reject failed imports of a public-key block even when GPG reports NODATA with zero import counts. Cover directories, truncated armor, readable binary keys and input changes with real-GPG regressions while preserving plain no-key text. Generated-by: OpenAI Codex (GPT-6)
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
keys-sync.Test plan
4556f693and pass with the repair.e1c2e10aand pass after the follow-up.prek run --all-filesincluding lychee passes in the Linux checkout; the two source files match the Windows workspace byte for byte.pre-first-pr-checkfor06056d2c: all five categories pass; ready with zero blocking items.06056d2c: no workflow run or check suite has been reported, including after a single close/reopen refresh that kept the PR Draft. Remote CI remains unverified; old-head success is not reused.RFC-AI-0004 compliance
Linked issues
Fixes fork issue #11.
Notes for reviewers
The branch starts at fork
main(4556f693) and contains no commits from Draft PR #9.The follow-up addresses a real omission found in reviewed head
e1c2e10a: NODATA plus zero counts does not establish that an input was read correctly or contains no malformed public-key block.The fix adds input evidence and imports one complete byte snapshot; it does not match English stderr or add a new status blacklist.
No key strength, signing-subkey admission, signer selection or signature verification policy changed.
This remains independent of upstream issue #1628, including Option 2.
Windows/MSYS homedir path compatibility remains unresolved; its production acceptance is an accurate error with exit 2.
Windows test-only homedir translation is a control experiment, and native Windows GPG was unavailable for separate verification.
No skill prompt or eval fixture changed.
The original nine-case print-mode author self-evaluation was a compatibility smoke check only: the existing Step 1 fixtures have no helper-error case, and model-layer error forwarding has not been independently evaluated.
The Windows eval renderer's baseline legacy-symlink issue is unchanged; earlier prompt rendering was performed in Linux.
Gen-AI disclosure: OpenAI Codex (GPT-6) assisted with the code, tests and text.
This Draft PR is submitted to the contributor's fork for human audit and does not claim completed human review.