Repository navigation
fix(ci-runner-audit): report incomplete scans (chat preview) - #3
Draft
MakerFlyFly wants to merge 1 commit into
Draft
MakerFlyFly wants to merge 1 commit into
MakerFlyFly wants to merge 1 commit into
Conversation
Preserve successful findings while recording workflow discovery, download, and parsing failures. Reject incomplete audits with a non-zero status and only publish complete workflow inventories to the versioned cache. Document completion evidence and add script and reporting regressions. Generated-by: Codex 0.159.0-alpha.12.1 (GPT-6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Draft PR previews the frozen version prepared in this chat: 26 scanner tests, 21 changed files, and 697 additions / 86 deletions.
It is based on upstream commit
bdbd66d0and the reviewed diff SHA-2568636fe29544c2840b0ed4d9f5e5da53880cec2565352f02fa3e1d42ec4209f9b.The separate later revision in the existing fork PR is preserved.
ghauthentication before discovery. Share one download and parse across the requested checks, and publish only complete workflow inventories atomically under a versioned cache filename.Type of change
ci-runner-audit, with updated eval fixturesTest plan
prek run --all-filespasses (Linux checkout with native symlinks,jq/ghinstalled, and a subprocess reaper)ruff check,ruff format --check, andmypypasstools/dev/run-skill-script-tests.shpassesgpt-6.1-solandgpt-6-luna, using prompts assembled from the edited skill by the existing eval harness1, missing PyYAML returns2, and a failed inventory refresh recovers on a healthy run without--refreshall --repo apache/magpie, 13 workflows completed,scan_errors=0RFC-AI-0004 compliance
Linked issues
Closes #2
Notes for reviewers
Existing findings TSV names and columns remain the same.
New
<scope>-scan-errors.tsvcolumns arerepo,path,stage,error, andhtml_url.Exit codes are
0for complete scans,1for incomplete scans/output failures, and2for unavailable prerequisites or invalid arguments.workflows_scannedcounts workflows that completed every requested check.Old
<owner>-workflow-files.tsvinventories are ignored and rebuilt as<owner>-workflow-files-v2.tsv; failed refreshes preserve the last complete cache without using it as the current run's result.The active authentication check runs even when a workflow inventory is reused.
Runner-label and architecture-matching rules are retained.
Generative AI assistance: this change was developed with Codex (GPT-6); the test and eval results above describe the verification performed.