Skip to content

fix: resolve GitHub logo navbar overlap on mobile, tablet and iPad Mini #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeeXD merged 1 commit into from
Jun 28, 2026
Merged

fix: resolve GitHub logo navbar overlap on mobile, tablet and iPad Mini #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/sections/Hero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ export default function DevHackHeroCompact() {
const isNothingPhone = /Nothing/i.test(ua) || /\bA063\b|\bA065\b|\bA142\b|\bA142P\b/i.test(deviceModel);
const is20x9 = Math.abs(ratio - 9 / 20) < 0.05;
const isZFold = /SM-F|Galaxy Z Fold|GalaxyZFold|Fold/i.test(ua);
const navEl = typeof document !== 'undefined' ? document.querySelector('header') : null;
const measuredNavHeight = navEl ? Math.round(navEl.getBoundingClientRect().height) : 0;
const navEl = typeof document !== 'undefined' ? document.querySelector('nav') : null;
const measuredNavHeight = navEl ? Math.round(navEl.getBoundingClientRect().bottom) : 0;
Comment on lines +72 to +73

setIsMobile(width < 768);
setIsTwentyNine(width < 768 && Math.abs(ratio - 20 / 9) < 0.06);
Expand Down Expand Up @@ -151,7 +151,7 @@ export default function DevHackHeroCompact() {
transform: isMobile ? `translateY(${mobileScrollY}px)` : 'none',
transition: isMobile ? 'transform 0.1s ease-out' : 'none',
willChange: 'transform',
paddingTop: !isXLDesktop && navHeight > 0 ? `${navHeight + 48}px` : !isXLDesktop ? '130px' : undefined,
paddingTop: !isXLDesktop && navHeight > 0 ? `${navHeight + 8}px` : !isXLDesktop ? '110px' : undefined,
marginTop: isNothing20x9
? '-24px'
: isTightHeroSpacingDevice
Expand All @@ -162,7 +162,7 @@ export default function DevHackHeroCompact() {
}}
>
{/* GitHub presents banner + title — single translated block */}
<div className="flex flex-col items-center z-10 md:-translate-y-12 pointer-events-none">
<div className="flex flex-col items-center z-10 pointer-events-none">
{/* GitHub presents — always above title */}
<div className="flex flex-col items-center mb-2 pointer-events-auto select-none">
<img
Expand Down