Conversation
ManimColor.gradient() was a public static method that raised NotImplementedError despite having a documented signature and return type. Implement it by delegating to the module-level color_gradient(), and add tests covering zero length, empty input, single-color input, endpoint interpolation, and parity with the module function. Closes ManimCommunity#4802
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ManimColor.gradient()is a public static method with a documented signature and return type, but it raisesNotImplementedError. Users discovering it via autocomplete or API docs get misled (the docstring redirected to the module-levelcolor_gradient).Change
ManimColor.gradient(colors, length)by delegating to the existingcolor_gradient()logic (single source of truth).list[ManimColor](the oldManimColor | list[ManimColor]was inaccurate — it always returns a list).Tests
Added in
tests/module/utils/test_color_helpers.py:ValueErrorcolor_gradient()All 10 gradient tests pass.
Closes #4802