Repository navigation
Conversation
The OIDC tests only asserted one rejection (valid signature, wrong nonce); nothing checked that a correctly signed token is accepted, and ES256/ES384, the algorithms verified by p256/p384, had no coverage at all. Parameterise the mock provider over RS256, ES256 and ES384 and assert, for each: a valid token is accepted with the expected identity, a token signed by a key the JWKS does not publish is rejected, and a token whose claims were altered after signing is rejected. This is the baseline for moving openidconnect to a release built on p256/p384 0.14 (#425): the same tests must stay green across the upgrade. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Frontend SPA coverage (by module)
Generated from Vitest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds the regression baseline that must stay green across the
openidconnectupgrade needed for RUSTSEC-2026-0387:p256/p384, had no coverage.p256andp3840.13, already in the tree (lockfile gains two lines).No production code changes.
Verification (on openidconnect 4.0.1)
cargo test -p marreq-core --lib auth::provider: 10 passedcargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings: passcargo deny check advisories: ok (still relies on the stopgap ignore from fix(deps): clear cargo-deny and npm audit advisories blocking CI #426)Plan for #425 and status (Route A: wait for the upstream release)
Upstream
ramosbugs/openidconnect-rsmainalready has "Bump p256 and p384 to fix RUSTSEC-2026-0387" (crate version 4.1.0, MSRV 1.88), but the latest published release is still 4.0.1.elliptic-curve0.14 requirescrypto-bigint ^0.7.8, which satisfies the advisory.mainopenidconnectto 4.1.0 once released; bump thep256/p384dev-deps to 0.14 with it; checkoauth25.0.0 compatibility; fix any API changes inmarreq-core/src/auth/provider.rs; confirmcargo tree -i crypto-bigint@0.5.5is emptyRUSTSEC-2026-0387ignore fromdeny.tomlcargo deny check advisorieswithout the ignore; clippy, fmt and the Rust workspace tests;delegated_oauth_postgres_integrationandauth_public_integration_test; these tests unchanged and green; a before/after list of supported signing algorithms for explicit review; a manual login against a real provider if one is availableCloses #425and the before/after algorithm listSteps 2 to 5 are not started. The upstream release date is unknown, and nothing has been asked of the upstream project.
Merge guidance
This PR is safe to merge on its own, because it only adds tests, so it can land before the upgrade. Until then, #425 stays open and the
deny.tomlignore stays in place.Refs #425
🤖 Generated with Claude Code