🧪 Add unit tests for formatFindResultStatus and findReplaceShell - #46
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f49da55319
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| platform: 'node', | ||
| target: 'node22', | ||
| }); | ||
| const mod = await import(pathToFileURL(outfile).href); |
There was a problem hiding this comment.
Because esbuild emits this format: 'cjs' bundle through module.exports, Node's dynamic import() exposes the generated exports under default rather than as named properties on the module namespace. Consequently the destructuring on line 32 assigns both helpers as undefined, and the first assertion fails with TypeError whenever this test runs. Load the file with createRequire() like the repository's other CJS-bundle tests, or destructure mod.default.
Useful? React with 👍 / 👎.
🎯 What: Added unit tests for formatFindResultStatus and wrapMatchIndex in src/find/findReplaceShell.ts.
📊 Coverage: Tested empty/whitespace queries, zero/negative match counts, 1-based index formatting, and wrap-around match navigation.
✨ Result: Enhanced test coverage and reliability for find/replace shell utility functions.
PR created automatically by Jules for task 13105832827934219125 started by @MarsLuay