🧹 Refactor deeply nested code in PresentationEngine.ts - #53
Conversation
Extract getRunFontSizePt and resolveParagraphRangeFontSizePt helper functions from PresentationEngine.ts getRangesFontSizePt method to reduce nesting and improve maintainability.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What:
Extracted
getRunFontSizePtandresolveParagraphRangeFontSizePthelper functions fromgetRangesFontSizePtinsrc/PresentationEngine.ts.💡 Why:
Address deeply nested loop logic in
getRangesFontSizePt, improving readability and maintainability without altering functionality.✅ Verification:
Ran
npm run typecheckandnpm test. All 684 unit tests and type checks passed.✨ Result:
Flatter, cleaner, and more readable code structure in
PresentationEngine.ts.PR created automatically by Jules for task 312407958464912652 started by @MarsLuay