🧹 refactor buildClassicPlotXml into modular chart plot builders - #62
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What:
Refactored the long
buildClassicPlotXmlfunction insrc/powerpoint/chartInsertTypes.tsby extracting dedicated plot XML builder helper functions (buildColumnPlot,buildBarPlot,buildLinePlot,buildAreaPlot,buildPiePlot,buildRadarPlot,buildScatterPlot,buildStockPlot,buildSurfacePlot, andbuildComboPlot).💡 Why:
Improves code maintainability and readability by breaking down a large function with a complex switch statement into small, single-responsibility helper functions.
✅ Verification:
npm run typecheckto confirm type safety.node --test tests/audit-pptx-chart-types.test.mjs) verifying all chart type insertions and XML outputs.npm test) with zero failures.✨ Result:
buildClassicPlotXmlis now concise and readable, delegating plot construction to focused helper functions while preserving exact XML output behavior.PR created automatically by Jules for task 4501528955067469290 started by @MarsLuay