Skip to content

⚡ optimize find search index filtering loops and string allocations #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarsLuay merged 2 commits into from
Aug 25, 2026
+36 −9
Merged

⚡ optimize find search index filtering loops and string allocations #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2151be2
perf: optimize find search index filtering loops and allocations
MarsLuay Aug 25, 2026
51134dc
perf: optimize find search index filtering loops and allocations
MarsLuay Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 36 additions & 9 deletions src/powerpoint/findSearchIndex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ export interface PowerPointFindSearchIndexSlide {
slideIndex: number;
shapeMatches: PowerPointFindMatch[];
fallbackText: string;
lowerShapeTexts?: string[];
lowerFallbackText?: string;
}

/**
Expand All @@ -29,11 +31,15 @@ export function createFindSearchIndexSlideFromOoxml(
): PowerPointFindSearchIndexSlide {
const slideDocument = parseXml(slideXml, `slide ${slideIndex + 1}`);
const shapeMatches: PowerPointFindMatch[] = [];
const lowerShapeTexts: string[] = [];
const addShape = (shape: Element, shapeIndex: number): void => {
const text = normalizeSearchText(
getDescendants(shape, 't').map((element) => element.textContent ?? '').join(''),
);
if (text) shapeMatches.push({ slideIndex, shapeIndex, text });
if (text) {
shapeMatches.push({ slideIndex, shapeIndex, text });
lowerShapeTexts.push(text.toLocaleLowerCase());
}
};

const shapes = getShapeChildren(getShapeTree(slideDocument));
Expand All @@ -46,10 +52,14 @@ export function createFindSearchIndexSlideFromOoxml(
.forEach((child, childIndex) => addShape(child, (shapeIndex * 1000) + childIndex));
});

const fallbackText = normalizeSearchText(slideDocument.documentElement.textContent ?? '');

return {
slideIndex,
shapeMatches,
fallbackText: normalizeSearchText(slideDocument.documentElement.textContent ?? ''),
fallbackText,
lowerShapeTexts,
lowerFallbackText: fallbackText.toLocaleLowerCase(),
};
}

Expand All @@ -66,13 +76,30 @@ export function collectFindMatchesFromSearchIndex(

const matches: PowerPointFindMatch[] = [];
for (const slide of searchIndex) {
const shapeMatches = slide.shapeMatches.filter((match) => (
match.text.toLocaleLowerCase().includes(normalizedQuery)
));
if (shapeMatches.length > 0) {
matches.push(...shapeMatches);
} else if (slide.fallbackText.toLocaleLowerCase().includes(normalizedQuery)) {
matches.push({ slideIndex: slide.slideIndex, shapeIndex: null, text: slide.fallbackText });
let slideHasMatch = false;
const shapeMatches = slide.shapeMatches;
let lowerShapeTexts = slide.lowerShapeTexts;
if (!lowerShapeTexts || lowerShapeTexts.length !== shapeMatches.length) {
lowerShapeTexts = shapeMatches.map((match) => match.text.toLocaleLowerCase());
slide.lowerShapeTexts = lowerShapeTexts;
}

for (let i = 0; i < shapeMatches.length; i++) {
const match = shapeMatches[i];
const lowerText = lowerShapeTexts[i];
if (match && lowerText !== undefined && lowerText.includes(normalizedQuery)) {
matches.push(match);
slideHasMatch = true;
}
}

if (!slideHasMatch && slide.fallbackText) {
const lowerFallback = slide.lowerFallbackText ?? (
slide.lowerFallbackText = slide.fallbackText.toLocaleLowerCase()
);
if (lowerFallback.includes(normalizedQuery)) {
matches.push({ slideIndex: slide.slideIndex, shapeIndex: null, text: slide.fallbackText });
}
}
}
return matches;
Expand Down