⚡ Optimize ShapeClipboard relationship handling and XML DOM caching - #66
Conversation
…ShapeClipboard Replace async copyShapeRelationships loop with synchronous relationship handling and in-memory XML document caching. This eliminates redundant XML parsing/serialization per copied shape and avoids unnecessary Promise microtask overhead during paste operations.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR optimizes the multi-shape paste performance in
ShapeClipboard.ts.💡 What:
copyShapeRelationshipsandensureRelatedPartfrom async functions to synchronous operations since all underlying XML parsing (parseXml) and DOM manipulations are fully synchronous.parsedDocumentsmap toPasteContextso XML documents (e.g._rels/.relsparts) are parsed once and updated in-memory across shape copies, only serializing to string at the end ofpasteSlideObjects.🎯 Why:
await copyShapeRelationships(...)inside aforloop over copied shape indices.📊 Measured Improvement:
PR created automatically by Jules for task 17129194115600119051 started by @MarsLuay