⚡ Avoid redundant defaultView resolution in getComputedStyle loops - #69
⚡ Avoid redundant defaultView resolution in getComputedStyle loops#69MarsLuay wants to merge 1 commit into
Conversation
Avoid redundant window scope lookups during getComputedStyle run loops in TextToolbarController and NativePowerPointView.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Resolved
runs[0]?.ownerDocument?.defaultView ?? windowonce prior to iterating through text runs ingetEffectiveFontSizePtandgetEffectiveFontFamilywithinTextToolbarControllerandNativePowerPointView.🎯 Why:
Accessing global window scope / property lookups redundantly on every run element during computed style detection adds unnecessary overhead. Hoisting defaultView resolution before the run loop avoids redundant scope lookups across SVG text runs.
📊 Measured Improvement:
While
getComputedStylemust still be called per SVG run element to resolve element-specific styles (e.g. fontSize and fontFamily across tspan runs), hoisting defaultView resolution prevents repetitive scope chain lookups during toolbar updates.PR created automatically by Jules for task 18242416053898985989 started by @MarsLuay