Repository navigation
Fix the live monitor line cut short or wrapping - #123
Merged
Merged
Conversation
The monitor read the terminal width with tput inside its background subshell, where stdout is the substitution's pipe and stdin is /dev/null, so it always got 80: on a wider terminal the text next to the progress bar was cut as if the terminal were 80 columns wide. tput now reads /dev/tty. The space left for that text came from a fixed 35 columns that missed the hint's brackets, counters longer than 7 characters and clocks past 9:59, so the line could overflow by a column or more and wrap, leaving stale lines on screen. Each part is now measured, one column kept spare, and cut text ends with an ellipsis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The monitor read the terminal width with tput inside its background subshell, where stdout is the substitution's pipe and stdin is /dev/null, so it always got 80: on a wider terminal the text next to the progress bar was cut as if the terminal were 80 columns wide. tput now reads /dev/tty.
The space left for that text came from a fixed 35 columns that missed the hint's brackets, counters longer than 7 characters and clocks past 9:59, so the line could overflow by a column or more and wrap, leaving stale lines on screen. Each part is now measured, one column kept spare, and cut text ends with an ellipsis.