Repository navigation
Revise ?? parsing and Information cleanup. - #1985
Conversation
90bc29e to
6997fb1
Compare
6997fb1 to
2ac50be
Compare
| return Node("Missing", String("UnknownSymbol"), pattern_token) | ||
|
|
||
| pattern_arg = String(value=pattern_str, location=pattern_token.pos) | ||
| long_form = Symbol("True" if want_long_form else "False") |
There was a problem hiding this comment.
where is long_form used/retrieved now?
There was a problem hiding this comment.
Good point. This needs more work.
By the way, even when that is fixed I fully expect there will be lots more to do. The first phase is just to get InformationData and InformationGridData exposed for formatting. After that we'll need to work on the formatters for each of the frontends.
There was a problem hiding this comment.
LongForm now reinstated. It now just limits what fields gets in the InformationData object.
This has been added elsewhere.
Revise parsing ?? so that it evaluates to a InformationData or InformationGridData. Evaluation methods moved out of Information class and into `mathics.eval.properties` The usual linting done of nearby code.
Report missing symbol more often
2ac50be to
ff2ca7b
Compare
LongForm now just indicates how much data is put into InformationData.
|
@mmatera is this good enough for a minimal reworking of Information? |
|
@rocky, sure! Merge it when you think it is ready. |
There is a lot more work do be done go get this near WMA. This is just a start. |
2 participants
Revise parsing
??, so that it evaluates to anInformationDataorInformationGridDataobject.LongForm -> False, now just limits the fields put into an
InformationDataobject.Evaluation methods have been moved out of the
Informationclass and intomathics.eval.propertiesThe usual linting has been done on nearby code.