Repository navigation
EvenQ, OddQ, PrimeQ: return False for non-atoms instead of crashing - #1992
Open
tombouctou wants to merge 1 commit into
Open
tombouctou wants to merge 1 commit into
tombouctou wants to merge 1 commit into
Conversation
Since Mathics3#1934 only atoms have an int_value property, so EvenQ[f[1]] and patterns such as _?EvenQ raised AttributeError on any expression. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1934, only atoms have an
int_valueproperty, butEvenQ.test,OddQ.testandPrimeQ.evalstill readn.int_valuedirectly. Any non-atomic argument now crashes the interpreter:The same crash happens in pattern tests such as
MatchQ[f[1], _?EvenQ]orCases[{2, f[2], 3}, _?OddQ]. On 10.0.1 these returnFalse(and{3}).This PR uses
get_int_value()frommathics.core.number, which returnsNonefor anything without an integer value.Tests: new cases in
test/builtin/test_testing_expressions.py(test_numerical_properties). They fail on current master and pass with this change.🤖 Generated with Claude Code