Repository navigation
Negative, Positive, NonNegative, NonPositive: decide for Infinity and -Infinity - #1996
Open
tombouctou wants to merge 1 commit into
Open
tombouctou wants to merge 1 commit into
tombouctou wants to merge 1 commit into
Conversation
… -Infinity These tests only had a rule for NumericQ arguments, and Infinity is not NumericQ, so Negative[Infinity] stayed unevaluated (WMA: False). Add the values for DirectedInfinity[1] and DirectedInfinity[-1]. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negative,Positive,NonNegativeandNonPositiveonly had a rule forNumericQarguments.Infinityis notNumericQ, so these tests stayed unevaluated on infinite values:This matters for code such as
And @@ Not /@ Negative /@ (2 {Infinity, i, j} - {i, j, 0}), which never decides.This PR adds the values for
DirectedInfinity[1]andDirectedInfinity[-1]to the four functions.ComplexInfinityand other directions stay unevaluated.Tests: new cases in
test/builtin/test_testing_expressions.py(test_numerical_properties) and a doctest inNegative.🤖 Generated with Claude Code