Repository navigation
Give FileFormat XML for XML files on every platform - #2009
Merged
Merged
Conversation
Without libmagic, FileFormat["ExampleData/InventionNo1.xml"] gave "XSL" on macOS: the extension guess gives "application/xml", and mimetypes.guess_extension() maps that to ".xsl" when there is no /etc/mime.types. Map the XML MIME types explicitly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without libmagic,
FileFormat["ExampleData/InventionNo1.xml"]givesXSLon macOS, andtest_FileFormatfails there.Without libmagic, the type is guessed from the extension:
.xml→application/xml→mimetypes.guess_extension("application/xml"). Without an/etc/mime.typesfile (as on macOS), Python returns.xslfor that, since it is the first extension registered forapplication/xml. With libmagic the MIME type istext/xml, which happens to map to.xml.This maps
application/xmlandtext/xmltoXMLexplicitly before askingmimetypes. A unit test forfiletype_from_mime_contentchecks it on every platform.(The other two
test_FileFormatcases, a ZIP stored as.mxand a JPEG stored as.txt, need libmagic for content detection; withbrew install libmagic, as in the macOS CI workflow, they pass.)🤖 Generated with Claude Code