fix(tracking): skip bad Firefox carets and container-sized focus (#278) - #279
Merged
Merged
Conversation
…focus (#278) Firefox in a zoomed iframe (a Claude artifact at high Ctrl+ zoom) reports the caret, through both GetGUIThreadInfo and UIA, outside the focused input (input 2226,997 798x74, caret 3097,1226 1x118), so the view showed empty page. A caret whose centre is outside its element is now skipped. Leaving a text box moves focus to the whole page, and centring on it dropped the view; focus rects covering half the monitor or more are skipped. Both logged under trackLog. Version 0.10.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
Field: in the zoomed Firefox iframe both caret sources are wrong (the UIA caret and the element bounds point above the text, the Win32 caret below), so there is no source to fall back to. The skip now applies only to MozillaWindowClass windows; every other app keeps its 0.10.3 caret behaviour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #278.
MozillaWindowClass), a caret whose centre is outside its focused element is skipped, so the view stays put. Firefox inside a zoomed iframe (a Claude artifact at high Ctrl+ zoom) reports wrong positions from both the Win32 and UIA sources. Other apps keep their 0.10.3 caret behaviour.src/track_filter.hwith doctests built from the field-recorded numbers; findings indocs/TRACKING-FINDINGS.md.Verification
build.bat test: all doctests pass (newtest_track_filter.cpp)🤖 Generated with Claude Code
https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG