fix(windows): clean up qpdf staging files - #94
Merged
McanKul merged 1 commit intoAug 30, 2026
Conversation
Remove temporary downloads and extracted files in a finally block while preserving staged binaries and runtime DLLs. Refs McanKul#38
McanKul
approved these changes
Aug 30, 2026
McanKul
left a comment
Owner
There was a problem hiding this comment.
Thanks for the focused fix and thorough validation. I also verified the success and simulated failure paths locally; the staged binaries remain intact and the temporary directory is removed in both cases. Great first contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try/finallyand remove its temporary directory on success or failure.Why
Closes #38. Downloaded archives and extracted files currently remain in
offpdf-qpdf-*directories after the script exits.Validation
npm run buildnpm test(261 tests across 30 files)cargo check --manifest-path src-tauri/Cargo.toml(not run; no Rust changes)Privacy Checklist