Skip to content

test(home): add tool search matching helper - #95

Merged
McanKul merged 1 commit into
McanKul:developmentfrom
Shadorux:fix/tool-search-matching-92
Aug 31, 2026
Merged

test(home): add tool search matching helper#95
McanKul merged 1 commit into
McanKul:developmentfrom
Shadorux:fix/tool-search-matching-92

Conversation

@Shadorux

Copy link
Copy Markdown

Summary

  • add a pure tool-search matching helper for name, description, category, and explicit aliases
  • preserve category filtering, input ordering, and registry immutability
  • add focused Vitest coverage for matching and filtering behavior

Scope

  • HomePage.tsx and the search UI are intentionally not changed.

Verification

  • npm.cmd test -- src/lib/toolSearch.test.ts
  • npm.cmd test
  • npm.cmd run build

Closes #92

@McanKul

McanKul commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Thanks for the focused contribution! The helper keeps the matching rules pure and deterministic, and the test coverage is clear. I ran the full suite (31 files, 272 tests) and the production build successfully. We really appreciate you helping improve OffPDF — feel free to pick up another issue if you would like to contribute further.

@McanKul McanKul left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against issue #92. The helper is pure, preserves ordering and immutability, and covers names, descriptions, categories, aliases, normalization, and empty/no-result cases. Full test suite and build pass.

@McanKul
McanKul force-pushed the fix/tool-search-matching-92 branch from a84764d to 8e5ad01 Compare August 31, 2026 00:42

@McanKul McanKul left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after the branch update onto development. The helper remains pure and focused, and the full test suite (31 files, 272 tests) plus production build pass.

@McanKul
McanKul merged commit 2b1aa8b into McanKul:development Aug 31, 2026
2 checks passed
@Shadorux
Shadorux deleted the fix/tool-search-matching-92 branch August 31, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants