ci(release): check version metadata consistency - #96
Merged
McanKul merged 1 commit intoAug 31, 2026
Conversation
Compare npm, Cargo, and Tauri release versions before the frontend build. Report exact metadata fields and values on mismatch, with CLI regression tests for drift and missing or malformed metadata. Refs McanKul#68
McanKul
approved these changes
Aug 31, 2026
McanKul
left a comment
Owner
There was a problem hiding this comment.
Thanks @terminalchai — this is a solid implementation. I verified the version check, all 283 tests, and the production build locally; both CI jobs are green too. The field-level diagnostics and regression coverage are especially useful. We'd be glad to have you take on another issue anytime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run check:versionsto compare release versions inpackage.json, both root version fields inpackage-lock.json,src-tauri/Cargo.toml, the OffPDF package insrc-tauri/Cargo.lock, andsrc-tauri/tauri.conf.json.Why
Closes #68. The check catches source metadata drift without consulting Git tags or comparing unrelated dependency versions.
smol-tomlis a development-only dependency for parsing Cargo metadata correctly, including comments and quoted strings.Validation
npm run buildnpm test(283 tests across 32 files)cargo check --manifest-path src-tauri/Cargo.toml(not run; no Rust code changes)npm ciandnpm run check:versionspassed against the current 0.3.1 metadata.Privacy Checklist
smol-toml: BSD-3-Clause, development-only; no bundled binaries added).