Finish strict Calcit migration and fix diff flag rendering - #39
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The promised build-output CDN-prefix tests are absent and cannot run before the Vite build.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Completes the strict Calcit browser migration, fixes diff flag rendering, and strengthens CI/deployment validation.
Changes:
- Updates Calcit dependencies and browser entry configuration.
- Correctly unwraps explicit diff flags and expands runtime tests.
- Upgrades Vite and hardens CI validation and upload concurrency.
| File | Description |
|---|---|
.github/workflows/upload.yaml |
Strengthens validation, build, and upload workflow. |
.gitignore |
Ignores retired Calcit snapshots. |
README.md |
Documents canonical files and deployment behavior. |
calcit.cirru |
Migrates browser entry and fixes diff rendering. |
deps.cirru |
Updates Respo dependencies and removes Markdown. |
package.json |
Pins Vite 8.3.1. |
scripts/upgrade.test.mjs |
Adds generated-JS runtime coverage. |
yarn.lock |
Locks the Vite 8 dependency graph. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Calcit/procs 0.27.0, canonical snapshots, strict published Reel/UI dependency graph and all 27 public-definition checks. Remove unused Markdown only; preserve external fonts and original server rsync paths. Correct Option flag handling so unchanged/added chunks are not styled as removals.
Six existing generated-runtime tests cover line/word rendering, input callbacks, toggle/swap/clear operations, sorting and nested state preservation. Correction: the previously described five CDN build-output tests are not present, and no generated-HTML validation is claimed. Per maintainer request, use cos-upload-action v1.1.1 built-in public-base-url verification only, without an extra CDN checker.
Each PR run has an isolated concurrency group and preview prefix pr///; production paths unchanged. Vite receives the same base URL that the action verifies.
Existing partial type coverage/unsafe boundaries are not claimed eliminated. Earlier follow-up commit 6ce0826: CI 36817884392 succeeded. All 27 public definitions and 6 runtime tests passed; COS action internally verified all three uploaded frontend files at the isolated PR/run prefix. Review comments addressed; no production deployment or merge claimed.
Current follow-up commit 1c811f9 removes duplicate Calcit analyses while retaining Snapshot guards, six generated-runtime tests and per-run preview isolation. Actions run 36820594051 passed, including COS upload.