Repository navigation
fix(wire-agents): keep .claude/settings.json across a re-wire - #421
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ng Python Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
The merge ran as a bare command, so a non-zero exit ended the script before the restore. Wrap it in if ! ... then cp; WARN; fi. Tests: fake python3 that fails the merge, and one that truncates the target first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # CHANGELOG.md
This was referenced Oct 16, 2026
# Conflicts: # CHANGELOG.md
…s settings test The warning text and the fake-interpreter test wrappers name python3 on purpose. Mark them with portability-ok instead of weakening the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #419
wire-agents.shrunsmxcli init, which overwrites.claude/settings.json. It now snapshots the file first and merges after init: the project's entries win and keep their order, entries only mxcli's new file has are appended. Merge, not PRESERVE: PRESERVE restores the old bytes and would also drop anything a newer mxcli adds. An invalid-JSON snapshot is restored byte for byte.Impact
mxcli execdeny rule.bin/wire-agents.shnow sourcesbin/lib/portable.sh(require_py, python3 as install-claude-permissions.sh already does). Independent of #414.Test:
tests/wave2/test-wire-agents-settings.sh(profile + user entry + deny rule + hook survive, new mxcli entry added, idempotent); 4 of 6 checks fail on master. Kiro test still passes. check-pr-discipline clean.🤖 Generated with Claude Code