Repository navigation
fix(build-plan-status): read every skill-listed State like the phase card - #456
Merged
Merged
Conversation
… the phase card Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
build-plan-status.shonly readbuilt,done,not builtandpending a person. The build-plan skill listsbuilt/partial/not built/blocked, and the phase card (progress-report.py) also countscomplete,verified,in progressand similar. Such rows showed as "with a State cell this page cannot read" in the plan header and the phase got an "unknown" badge, while the card counted them.Change
partialandin progressroll up to an "in progress" phase;blockedcounts as not built (the card does the same) and is named in the header, "(N of them blocked)"; "not needed" style rows stay out of the count and rollup.tests/wave2/test-progress-report-polish.sh: P5 (plan with every State; card, header and badge agree; unreadable still reported) and P2b (a non-placeholder FAIL on a later stage stays FAIL; FAIL stays when the current stage is unknown). P5 fails on the base scripts (7 checks); the P2b checks guard behaviour the base already had.Before and after render of a neutral 3 phase fixture: before shows "5 with a State cell this page cannot read" and "unknown" badges; after shows "3 built, 1 partial, 4 not built (2 of them blocked)" and built / in progress / not built badges.
🤖 Generated with Claude Code