docs(merge-queue): direct merge never applies to a queue running in-place checks - #13035
Merged
Conversation
Contributor
Merge Protections🟢 All 5 merge protections satisfied — ready to merge. Show 5 satisfied protections🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
jd
approved these changes
Sep 28, 2026
Contributor
Merge Queue Status
This pull request spent 3 minutes 12 seconds in the queue, including 2 minutes 38 seconds running CI. Required conditions to merge
|
49 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page listed three conditions a pull request has to meet before the queue can
merge it without a queue CI run, and left out the one that decides it for a whole
class of repositories: the optimization is the decision to skip creating a batch
pull request, and a queue configured for in-place checks never reaches that
decision at all. Such a queue tests the pull request on its own branch, so there
is no batch pull request and no extra CI run for Direct Merge to remove.
Without that line a reader on a serial, single-check queue could read the
"already up to date" case as applying to them, conclude Direct Merge was broken
when the queue behaved no differently, and go looking for a configuration
mistake that does not exist.
Evidence: the batch-checking path that asks whether the batch pull request can be
skipped is only entered when the queue builds one; the in-place path is a
separate entry point that never consults it.