docs(ci-insights): names the same test on all three commits in the flaky-detection diagram - #13037
Merged
Conversation
…aky-detection diagram
Contributor
Merge Protections🟢 All 5 merge protections satisfied — ready to merge. Show 5 satisfied protections🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
jd
approved these changes
Sep 28, 2026
Contributor
Merge Queue Status
This pull request spent 3 minutes 11 seconds in the queue, including 2 minutes 37 seconds running CI. Required conditions to merge
|
49 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diagram explaining flaky detection labelled its first commit's test
test_something2while the other two commits both saidtest_something. Its owntitle reads "two runs of one test on three commits", and the sentence introducing
it says the runs are "two executions of the same tests on the exact same commit",
so the label contradicted both.
That matters more than a stray character, because the disagreement between two
runs of one test is the entire mechanism the page is explaining. A reader who
takes the labels at face value sees a diagram in which two different tests
produced two different results, which is not flakiness and is exactly the wrong
intuition to leave someone with on the page that defines it.