docs(merge-protections): says what an unparseable Merge-After header does, which is block forever… - #13051
Merged
Conversation
…does, which is block forever…
Contributor
Merge Protections🟢 All 5 merge protections satisfied — ready to merge. Show 5 satisfied protections🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
JulianMaurin
approved these changes
Sep 29, 2026
Contributor
Merge Queue Status
This pull request spent 2 hours 37 minutes 45 seconds in the queue, including 3 minutes 7 seconds running CI. Required conditions to merge
|
49 tasks
jd
approved these changes
Sep 29, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Merge-After section described the accepted timestamp format and stopped
there, so the page said nothing about the case a reader reaches by typing the
header slightly wrong.
A value the engine cannot parse is not rejected and does not fail the
protection. It pins the condition's target to the maximum representable
datetime, which
current-datetime >=can never reach, so the pull request sitsblocked for good with the check reporting the value back as invalid. That is
the one outcome somebody would never guess from a page describing only the
format, and the fix (correct the header) is not obvious while the check is
merely pending.
Evidence: the engine's Merge-After condition builder, which catches the invalid
date, substitutes the max datetime and sets the summary line the new text
quotes.
The page said the merge queue shows a pull request's dependencies "only for the
pull requests ahead of it in a stack in the same repository". That is the right
restriction but not the whole of it: the list the queue renders is built from
stack predecessors that are still embarked in a queue, so one that has merged
or been dequeued drops out of it.
Merging is the harmless half, since a merged dependency no longer blocks
anything. A dequeued one is not: it still blocks the merge if it is open, and
it disappears from the panel that exists to explain why the pull request is
waiting. The sentence now says which predecessors appear.
Evidence: the engine helper the merge queue status serializer calls for this
field, which returns the queued subset of a pull request's stack predecessors.
Open question: whether this section should also mention that GitHub-native
stacks populate the same panel without any
Depends-On:header. It is true,but it is gated per organization, and saying it on a page about the
Depends-Onheader would describe something most readers cannot turn on. I left it out.