Repository navigation
decompressZip overloads returning files via a callback - #7102
Merged
Merged
Conversation
…ving it on disk Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…_STAT libzip stats the source also in the middle of reading (when opening an entry), and getStreamSize returned only the size from the current position to the end; macOS libzip then failed to open the second entry of a stream. Also add libzip's error to "Cannot open zip file" message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Grantim
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
decompressZipoverloads (zip file path andstd::istream) that pass every file of the archive to a callback instead of saving it on disk:pathis relative inside the archive with/separators; folder entries and macOS__MACOSX/metadata are skipped.forEachZipEntry_, shared with the existing folder-extractingdecompressZip; the zip entry is now closed also when reading it fails.std::istreamzip source:ZIP_SOURCE_STATreturned the size from the current stream position to the end instead of the whole stream size. libzip stats the source also when opening an entry, in the middle of the stream, and on macOS failed to open the second entry. The bug was in the existing streamdecompressZiptoo; the new test is the first to cover it.MRMesh.DecompressZipToCallback.🤖 Generated with Claude Code