Repository navigation
Remove the checked-in python3XY.zip; MREmbeddedPython's build generates it with update_python_zip.py - #7113
Merged
Conversation
…hon_zip.py thirdparty/python/python311.zip and python312.zip (python.org's embeddable standard library) are deleted; the Windows builds no longer copy them next to python3XY.dll. Run scripts/update_python_zip.py --output <bin dir> instead, which builds the zip from the CPython sources of vcpkg's python3 port. Windows CI does that right after the build, with the py-launcher Python of the same minor version. The license manifest's Python entry now tracks the python3 vcpkg port. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fedr
added
disable-build-ubuntu-x64
disable-build-ubuntu-arm64
disable-build-macos
disable-build-emscripten
disable-build-linux-vcpkg
disable-build-macos-crossplatform
…as no Python Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… of a CI step (review) MREmbeddedPython.vcxproj gets a BuildPythonZip target after Build, and its CMakeLists.txt a custom command: both run scripts/update_python_zip.py with vcpkg's own tools/python3/python.exe, writing python3XY.zip next to python3XY.dll, only when the zip is missing or the script or that Python changed (skipped when vcpkg has no Python, e.g. the iterator-debug triplet). Every Windows build gets the zip, so the Windows CI step is removed. vcpkg's arm64 Python handles HTTPS since #7121. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fedr
changed the title
Grantim
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thirdparty/python/python311.zipandpython312.zipwere python.org's Windows embeddable standard library, checked in by hand and copied next topython3XY.dllby the Windows builds. Since #7101scripts/update_python_zip.pybuilds the same archive from the CPython sources of vcpkg's python3 port, so it always matches the Python vcpkg builds. This PR removes the checked-in archives and has the build ofMREmbeddedPython, the project that needs the zip, generate it.thirdparty/python/python311.zip,python312.zipandreadme.md.python311.zipwas unused: every Windows CI job uses vcpkg 2026.07.29, whose python3 port is 3.12.MREmbeddedPython.vcxprojgets aBuildPythonZiptarget afterBuild, which runs the script with vcpkg's owntools\python3\python.exeand writes$(OutDir)python$(PythonVersion).zip. Its inputs are the script and thatpython.exe, so it runs once and is skipped while the zip is up to date (checked locally: 36 s the first time, then "Skipping target BuildPythonZip because all output files are up-to-date"). It is skipped when vcpkg has no Python (the iterator-debug triplet).MREmbeddedPython/CMakeLists.txtreplaces the zip copy with a custom command and anALLcustom target doing the same, under the same conditions.python3vcpkg port (3.12.13#1, re-pinned withscripts/check_third_party_licenses.py --update-versions). The license text is unchanged.The zip built this way was checked against CPython's tagged sources (the
.pycfiles embed source hashes): it is 3.12.13, as is vcpkg'spython312.dll, while the checked-in one was python.org's 3.12.10.🤖 Generated with Claude Code