Skip to content

feat: add insert mode to edit tool - #228

Merged
seankmartin merged 2 commits into
feature/edit-modefrom
feat/insert-skeleton-node
Sep 25, 2026
Merged

seankmartin merged 2 commits into
feature/edit-modefrom
feat/insert-skeleton-node

Conversation

@seankmartin

@seankmartin seankmartin commented Sep 15, 2026 •

Copy link
Copy Markdown

Adds an insert mode to edit tool, you must click nodes which are directly connected for execution to go through. Intended to follow the existing patterns in the code base, and made with Claude since it shouldn't really be introducing any new concepts

@seankmartin
seankmartin merged commit f23f230 into feature/edit-mode Sep 25, 2026
1 check passed

@afonsobspinto afonsobspinto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the post merge review:

  1. Clearing the selection leaves the first insert node armed.
    Hold I, select node A, then use Ctrl+Shift+right-click to clear the selection. The existing clear-selection handler removes the selected node and any merge anchor, but it does not clear insertFirstNode. Consequently, clicking a neighbour B immediately inserts between A and B—even though A is no longer visibly selected.

  2. edge case: completion after deactivation can suppress selection highlighting again.

  3. very edge case: The midpoint can use an outdated first-node position. F.e:

  4. With the Skeleton tab open, move node A and wait for the edit to finish.

  5. Hold I and click A as the first insertion endpoint.

  6. Keep holding I, trigger an undo, and wait for it to finish.

  7. Keep I held, and click neighbouring node B.

Undo restores A’s previous position in the cache, but insertFirstNode still contains the snapshot captured before the undo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants