feat: picking indicator - #229
Open
seankmartin wants to merge 7 commits into
Open
seankmartin wants to merge 7 commits into
seankmartin wants to merge 7 commits into
Conversation
Overlays are intended for a very quick rendering for simple updates outside of the regular draw loop. They are rendered as DOM elements. Also added a title to all settings since this new setting felt it needed some explanation and didn't want to be inconsistent
seankmartin
marked this pull request as ready for review
September 17, 2026 16:25
Also clarify existing tests and check overlay draw order and disposal
seankmartin
marked this pull request as draft
September 23, 2026 12:09
The first round of overlays were a bit muddled between the display context and rendered data panels. And the viewer settings were also threaded through in the wrong pattern. This aims to simplify these patterns. Additionally fixes an issue with any clipped panels.
Shows position based on cursor but pick info based on last async pick
seankmartin
marked this pull request as ready for review
September 24, 2026 17:54
afonsobspinto
requested changes
Sep 25, 2026
| (visibleTopFraction + | ||
| (0.5 - (clip[1] / w) * 0.5) * visibleHeightFraction) * | ||
| logicalHeight, | ||
| focalPlaneDepthFraction: orthographic |
Member
There was a problem hiding this comment.
potential issue: This assumes the focal plane is halfway between the clipping planes. However, PerspectivePanel clamps the near plane with Math.max(0.1, 1 - relativeDepthRange) while leaving the far plane at 1 + relativeDepthRange. Once that clamp applies, the bounds are unequal distances from focus.
Member
There was a problem hiding this comment.
Some consequences are:
- Orthographic: the ring is almost invisible at focus and brightest at the clipping midpoint.
- Perspective: the ring disappears before reaching the far boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlays are intended for a very quick rendering for simple updates outside of the
regular draw loop. They are rendered as DOM elements.
Also added a title to all settings since this new setting felt it needed some
explanation and didn't want to be inconsistent