feat: add getSessionProperties to chain-agnostic-permissions. Use it in multichain-api-middleware#9294
Open
jiexi wants to merge 4 commits into
Open
feat: add getSessionProperties to chain-agnostic-permissions. Use it in multichain-api-middleware#9294jiexi wants to merge 4 commits into
chain-agnostic-permissions. Use it in multichain-api-middleware#9294jiexi wants to merge 4 commits into
Conversation
jiexi
changed the title
chain-agnostic-permissions. Use it in multichain-api-middleware
Member
Author
|
@metamaskbot publish-previews |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Breaking middleware hook contract for all consumers of wallet session RPC handlers; capability data now depends on host-provided getCapabilities behavior at session read/create time.
Overview
Adds
getSessionPropertiesin@metamask/chain-agnostic-permission, which spreads stored CAIP-25sessionPropertiesand adds acapabilitiesmap built by callinggetCapabilitiesonce per unique permitted EVM address (viagetEthAccounts); non-EVM accounts are skipped.wallet_createSessionandwallet_getSessioninmultichain-api-middlewarenow returnsessionPropertiesthrough this helper instead of only the persisted caveat fields.wallet_getSessionalways includessessionProperties(including{}when there is no session).Breaking: integrators must supply a
getCapabilitieshook onWalletCreateSessionHooksandWalletGetSessionHookswhen wiring these handlers.Reviewed by Cursor Bugbot for commit e1c7d28. Bugbot is set up for automated code reviews on this repo. Configure here.