fix(bitcoin-wallet-snap): Extract error messages from error objects - #179
Merged
Conversation
FrederikBolding
changed the title
FrederikBolding
marked this pull request as ready for review
August 20, 2026 11:59
FrederikBolding
enabled auto-merge
August 20, 2026 12:00
ulissesferreira
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
It seems that in some cases errors from the BDK end up in
HandlerMiddlewarethat are plain objects with amessageattached. The current logic doesn't account for these, but thegetErrorMessageutility does. This PR adjusts the logic slightly.References
https://metamask.sentry.io/issues/7669756811/?project=2299799&query=release%3A%22io.metamask%408.6.0%2B6401%22&referrer=release-issue-stream
Checklist