Skip to content

Register 80hours reminder and platform schemas #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EgorPPS wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Register 80hours reminder and platform schemas #1101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions services/ontology/schemas/groupReference.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"schemaId": "0f9a3cb8-4a9f-4b5f-a1fa-3a4c2eb1f410",
"title": "GroupReference",
"type": "object",
"description": "A user-side reference to the canonical GroupManifest for a company or project. It intentionally carries no duplicate group membership or role data.",
"additionalProperties": false,
"required": [
"id",
"isReference",
"entityType",
"canonicalEntityId",
"canonicalOwnerEName",
"canonicalEnvelopeId",
"groupManifestEnvelopeId",
"createdAt",
"updatedAt"
],
"properties": {
"id": { "type": "string" },
"isReference": { "type": "boolean", "const": true },
"entityType": { "type": "string", "enum": ["company", "project"] },
"canonicalEntityId": { "type": "string" },
"canonicalOwnerEName": { "type": "string" },
"canonicalEnvelopeId": { "type": "string" },
"groupManifestEnvelopeId": { "type": "string" },
"createdAt": { "type": "string", "format": "date-time" },
"updatedAt": { "type": "string", "format": "date-time" }
}
}
31 changes: 31 additions & 0 deletions services/ontology/schemas/platformSelfDescription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"schemaId": "0f9a3cb8-4a9f-4b5f-a1fa-3a4c2eb1f411",
"title": "PlatformSelfDescription",
"type": "object",
"description": "A machine-readable self-description of a W3DS post-platform, stored on the platform's own eVault.",
"additionalProperties": false,
"properties": {
"id": { "type": "string" },
"platformName": { "type": "string" },
"displayName": { "type": "string" },
"format": { "type": "string" },
"content": { "type": "string" },
"contentSha256": { "type": "string" },

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Verify the encoding emitted and consumed for contentSha256.
rg -n -C 4 --glob '*.js' --glob '*.ts' --glob '*.json' \
  '"contentSha256"|contentSha256' services

Repository: MetaState-Prototype-Project/prototype

Length of output: 1781

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'Files mentioning contentSha256:\n'
rg -n -C 3 'contentSha256' . || true

printf '\nSchema files:\n'
git ls-files 'services/ontology/schemas/*.json'
printf '\nPlatform self-description schema:\n'
cat -n services/ontology/schemas/platformSelfDescription.json

Repository: MetaState-Prototype-Project/prototype

Length of output: 4131

Constrain contentSha256 to the expected SHA-256 digest format.

contentSha256 is required but the schema only treats it as a generic string, which allows empty, truncated, or malformed values. Define the single encoding used for consumers, such as 64-character hexadecimal, and enforce it with pattern.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@services/ontology/schemas/platformSelfDescription.json` at line 14, Constrain
the contentSha256 property in the platform self-description schema to the
consumer-defined SHA-256 encoding: retain its string type and add a pattern
requiring exactly 64 hexadecimal characters, rejecting empty, truncated, and
malformed digests.

"sourceUrl": { "type": "string" },
"profileEnvelopeId": { "type": "string" },
"createdAt": { "type": "string", "format": "date-time" },
"updatedAt": { "type": "string", "format": "date-time" }
},
"required": [
"id",
"platformName",
"displayName",
"format",
"content",
"contentSha256",
"profileEnvelopeId",
"createdAt",
"updatedAt"
]
}
71 changes: 71 additions & 0 deletions services/ontology/schemas/reminder.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"schemaId": "0f9a3cb8-4a9f-4b5f-a1fa-3a4c2eb1f412",
"title": "Reminder",
"type": "object",
"description": "A universal reminder/alarm envelope. It can point to any W3DS subject, not only a task. The timing model is compatible with iCalendar VALARM absolute triggers.",
"additionalProperties": true,

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Make the top-level Reminder contract strict.

Line 7 permits every undeclared top-level field. This conflicts with the stated strict-schema contract and allows misspelled or unsupported fields to validate. Set additionalProperties to false. Define an explicit extension field if extensibility is required.

Proposed fix 
-  "additionalProperties": true,
+  "additionalProperties": false,
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"additionalProperties": true,
"additionalProperties": false,
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@services/ontology/schemas/reminder.json` at line 7, Update the top-level
Reminder schema’s additionalProperties setting to false so undeclared fields are
rejected; if supported extensibility is required, define an explicit extension
field rather than allowing arbitrary top-level properties.

"required": [
"id",
"canonicalOwnerEName",
"createdBy",
"recipientEName",
"triggerAt",
"action",
"summary",
"status",
"relatedSubject",
"createdAt",
"updatedAt"
],
"properties": {
"id": { "type": "string" },
"canonicalOwnerEName": { "type": "string" },
"createdBy": { "type": "string" },
"recipientEName": { "type": "string" },
"triggerAt": {
"type": "string",
"format": "date-time",
"description": "Absolute reminder trigger time, equivalent to VALARM TRIGGER;VALUE=DATE-TIME."
},
Comment on lines +26 to +30

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Trace Reminder scheduling and trigger interpretation.
rg -n -C 5 --glob '*.js' --glob '*.ts' --glob '*.json' \
  '"triggerKind"|"triggerAt"|"relativeTo"|"offset"|"Reminder"' services

Repository: MetaState-Prototype-Project/prototype

Length of output: 3219

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== reminder.json =="
cat -n services/ontology/schemas/reminder.json | sed -n '1,120p'

echo
echo "== schema references to reminder trigger fields =="
rg -n -C 6 --glob '*.js' --glob '*.ts' --glob '*.json' \
  '"triggerKind"|"triggerAt"|"snoozedUntil"|"relatedSubject"|"REMINDER"' services | sed -n '1,240p'

Repository: MetaState-Prototype-Project/prototype

Length of output: 8197

Handle triggerKind: "relative" in the schema.

Reminder still requires an absolute triggerAt for every reminder, including triggerKind: "relative". Remove the relative option or add conditional schemas that require absolute times and separate required relative fields such as offset and subject-time anchor.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@services/ontology/schemas/reminder.json` around lines 26 - 30, Update the
Reminder schema around triggerAt to handle triggerKind "relative" explicitly:
either remove the relative trigger option, or add conditional schemas so
absolute triggers require triggerAt while relative triggers require the
appropriate offset and subject-time anchor fields. Ensure reminders are not
forced to provide triggerAt when using the relative form.

"timezone": { "type": "string", "default": "UTC" },
"action": {
"type": "string",
"enum": ["display", "email", "audio"],
"default": "display"
},
"summary": { "type": "string" },
"description": { "type": "string" },
"status": {
"type": "string",
"enum": ["scheduled", "acknowledged", "dismissed", "cancelled"],
"default": "scheduled"
},
"acknowledgedAt": { "type": ["string", "null"], "format": "date-time" },
"snoozedUntil": { "type": ["string", "null"], "format": "date-time" },
"standard": {
"type": "string",
"description": "Optional interoperability hint, for example RFC5545-VALARM."
},
"triggerKind": {
"type": "string",
"enum": ["absolute", "relative"],
"default": "absolute"
},
"relatedSubject": {
"type": "object",
"description": "Structured pointer to the subject. Readers can resolve this to learn whether the subject is a task, event, message, birthday, payment, shopping item, or another W3DS entity.",
"required": ["id"],
"additionalProperties": true,
"properties": {
"id": { "type": "string" },
"ontologyId": { "type": "string" },
"canonicalOwnerEName": { "type": "string" },
"canonicalEnvelopeId": { "type": ["string", "null"] },
"type": { "type": "string" }
}
},
"createdAt": { "type": "string", "format": "date-time" },
"updatedAt": { "type": "string", "format": "date-time" }
}
}
26 changes: 11 additions & 15 deletions services/ontology/schemas/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,42 +63,38 @@
"deadline": { "type": ["string", "null"], "format": "date-time" },
"blockedByTaskIds": { "type": "array", "items": { "type": "string" } },
"blocksTaskIds": { "type": "array", "items": { "type": "string" } },
"notes": { "type": "array", "items": { "$ref": "#/definitions/note" } },
"attachments": { "type": "array", "items": { "$ref": "#/definitions/attachment" } },
"subtasks": { "type": "array", "items": { "$ref": "#/definitions/subtask" } },
"effectiveAcl": { "type": "array", "items": { "type": "string" } },
"notes": { "type": "array", "items": { "$ref": "#/definitions/note" }, "description": "Deprecated legacy inline copy. New notes are canonical TaskNote envelopes." },
"attachments": { "type": "array", "items": { "$ref": "#/definitions/attachment" }, "description": "Deprecated legacy inline copy. New attachments are canonical TaskAttachment envelopes." },
"subtasks": { "type": "array", "items": { "$ref": "#/definitions/subtask" }, "description": "Deprecated legacy inline copy. New subtasks are Task envelopes linked through task relations." },
"effectiveAcl": { "type": "array", "items": { "type": "string" }, "description": "Deprecated projection. The sole authoritative access list is MetaEnvelope.acl." },
"manualAclAdds": { "type": "array", "items": { "type": "string" } },
"aiDraftSource": { "type": "string" },
"eVaultSyncStatus": { "type": "string", "enum": ["synced", "pending", "failed"] },
"eVaultSyncError": { "type": ["string", "null"] },
"createdAt": { "type": "string", "format": "date-time" },
"updatedAt": { "type": "string", "format": "date-time" },
"closedAt": { "type": ["string", "null"], "format": "date-time" }
"closedAt": { "type": ["string", "null"], "format": "date-time" },
"isDeleted": {
"type": "boolean",
"default": false,
"description": "Soft-delete marker. Readers should hide deleted tasks from ordinary lists while preserving the canonical envelope for references and audit."
}
},
"required": [
"id",
"canonicalOwnerEName",
"relatedProjectIds",
"relatedCompanyIds",
"title",
"description",
"createdBy",
"assignees",
"status",
"priority",
"progressPercent",
"estimatedHours",
"deadline",
"blockedByTaskIds",
"blocksTaskIds",
"notes",
"attachments",
"subtasks",
"effectiveAcl",
"manualAclAdds",
"createdAt",
"updatedAt",
"closedAt"
"updatedAt"
],
"additionalProperties": false
}
Loading