Conversation
Changes: - Stack detection keypoints once and vectorize each ground truth comparison across detections. - Preserve baseline per-row reduction order and add visible/unlabeled keypoint regression coverage. Impact: - Fixed direct computeOks workload improved from 0.023877019 s to 0.003949417 s (6.05x) with bit-identical output. Verification: - pre-commit run --files faster_coco_eval/core/cocoeval.py tests/test_compute_oks.py - python -m pytest -p no:rerunfailures -q (147 passed, 2 skipped) Residual limits: - Performance evidence covers one macOS arm64 direct-call workload; CI and broader workload coverage remain unobserved. --- Co-authored-by: Codex <codex@openai.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Vectorizes OKS computation across detections while preserving numerical behavior.
Changes:
- Stacks detection keypoints for vectorized distance calculations.
- Adds visible and unlabeled keypoint regression coverage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
faster_coco_eval/core/cocoeval.py |
Vectorizes per-ground-truth OKS calculations. |
tests/test_compute_oks.py |
Verifies bit-identical OKS outputs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
@MiXaiLL76 seems to be ready for review... |
Collaborator
Author
|
@MiXaiLL76 could you pls have a look... 🐰 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Impact:
Verification:
Residual limits:
part of #80