! -- update PublishCodeCoverageResults@2 references to drop @1 - #14392
! -- update PublishCodeCoverageResults@2 references to drop @1#14392kk-hasuwae wants to merge 3 commits into
PublishCodeCoverageResults@2 references to drop @1#14392Conversation
parameters. `codeCoverageTool` and `reportDirectory` were dropped in `@2`.
|
@microsoft-github-policy-service agree |
|
kk-hasuwae : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
kk-hasuwae : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Steve Danielson (@steved0x) Rami Bououni (@ramiMSFT) Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Pull request overview
This PR updates Azure Pipelines documentation samples to remove PublishCodeCoverageResults@2 inputs that appear to be associated with older task usage, and fixes a small markdown list formatting issue.
Changes:
- Removes
codeCoverageTooland/orreportDirectoryinputs from severalPublishCodeCoverageResults@2YAML snippets. - Adjusts related content in Python/Ruby coverage sections (via follow-up recommendations) to keep the narrative consistent with the simplified snippets.
- Fixes a malformed bullet in Related content in the Python customization article.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/pipelines/ecosystems/ruby.md | Simplifies PublishCodeCoverageResults@2 examples; needs surrounding text to match the updated snippet behavior. |
| docs/pipelines/ecosystems/dotnet-core.md | Removes codeCoverageTool from the coverage publishing snippet. |
| docs/pipelines/ecosystems/customize-python.md | Removes codeCoverageTool from the snippet and fixes a bullet list indentation issue. |
| docs/pipelines/ecosystems/customize-javascript.md | Removes v1-style inputs in a @1 example; still contains a v1 task reference that conflicts with PR intent. |
| docs/pipelines/customize-pipeline.md | Removes reportDirectory from a JaCoCo coverage publishing snippet. |
Suppressed comments (1)
docs/pipelines/ecosystems/customize-javascript.md:553
- The paragraph introducing this snippet links to the v1 task reference and says the task lets you download HTML reports, but the sample below is being moved away from v1-style usage and no longer specifies a report directory. Consider updating the link to the v2 reference and removing the HTML-download claim (or adding separate guidance for publishing the HTML report).
inputs:
summaryFileLocation: '$(System.DefaultWorkingDirectory)/**/*coverage.xml'
…@1 -> @2 in customize-javascript
…v2 in customize-javascript
|
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. Rami Bououni (@ramiMSFT), Steve Danielson (@steved0x) |
Updates to ensure that
PublishCodeCoverageResults@2doesn't reference v1 parameters. Not sure if the surrounding text needs adjusting as well; but this seems pretty solid so far.