Clarify Symbol enum values vs. Segoe MDL2 glyph code points (refs #2363) - #2558
Merged
John Kennedy (GrantMeStrength) merged 1 commit intoSep 11, 2026
Conversation
Distinguish each enum member's numeric value (e.g. Setting = 57621 / 0xE115) from the recommended font glyph code point (e.g. E713 for the settings glyph). Add an IMPORTANT alert to the description, clarify the Setting field, and link the maintained Segoe Fluent Icons catalog. No enum members were renumbered, removed, or reordered. Refs #2363 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
prmerger-automator
Bot
added
do-not-merge
Copilot started reviewing on behalf of
John Kennedy (GrantMeStrength)
September 11, 2026 14:19
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation accurately explains the mapping behavior and provides valid usage examples.
Pull request overview
Clarifies the distinction between Symbol enum values and recommended glyph code points.
Changes:
- Documents legacy code-point behavior and preferred icon usage.
- Adds
Settingguidance and maintained catalog links.
File summaries
| File | Description |
|---|---|
windows.ui.xaml.controls/symbol.md |
Clarifies enum and glyph mappings without altering enum data. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #2363. The
Windows.UI.Xaml.Controls.Symbolenum page conflated two different things: each enum member's numeric value (e.g.Setting = 57621/0xE115) and the recommended font glyph code point for that icon (e.g.E713for the settings glyph). This PR clarifies that distinction without changing any enum data.What changed
Focused edits to
windows.ui.xaml.controls/symbol.mdonly:## -description— added a prominent> [!IMPORTANT]alert explaining that the numeric constant is the enum member value, not necessarily the recommended glyph code point; giving the concreteSettingexample (57621 / 0xE115 vs. recommended code point E713); noting that legacy E0xx–E5xx code points can render as garbled characters in some contexts (e.g. CJK locales) and aren't recommended for direct use; and showing both reference approaches, plus links to the maintained catalogs.Settingfield — added a clarifying paragraph after the existing (unchanged) value/image lines.## -see-also— added a link to the maintained Segoe Fluent Icons font catalog, keeping existing links.How each approach works
Reference a glyph by name (resolves the correct glyph automatically):
Use a maintained code point directly:
Non-goals / guarantees
### -fieldlines are byte-for-byte unchanged, includingSetting:57621and itsE115image line.Refs #2363. The issue should remain open until this correction is published.