DEVOPS-1133: Pin GitHub Actions to commit hashes - #747
Open
RomFloreani wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to harden the repository’s GitHub Actions supply chain by moving uses: references away from floating tags; the current diff updates several workflow files by expanding @vN references to full semver tags (e.g., @v4 → @v4.4.0).
Changes:
- Expanded
actions/checkoutandmamba-org/setup-micromambareferences to full semver tags in CI workflows. - Updated
codecov/codecov-actiontov4.6.0in the Windows pytest workflow. - Updated Jira-related workflow references (
MiraGeoscience/CI-toolsreusable workflow andpeter-evans/create-or-update-comment) to full semver tags.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/static-analysis.yml | Expands checkout/micromamba action refs to full semver tags for static analysis job. |
| .github/workflows/pytest-windows.yml | Expands checkout/micromamba and updates Codecov action ref to full semver tags for Windows tests. |
| .github/workflows/pytest-unix-os.yml | Expands checkout/micromamba action refs to full semver tags for Unix tests. |
| .github/workflows/pr_jira_actions.yml | Expands reusable Jira workflow ref to a full semver tag. |
| .github/workflows/issue_to_jira.yml | Expands comment action ref to a full semver tag for Jira issue linkage. |
Comments suppressed due to low confidence (1)
.github/workflows/pytest-windows.yml:57
- This workflow step still uses
codecov/codecov-action@v4.6.0(a mutable tag). To match the PR goal of pinning actions, switch this to the exact commit SHA with a Dependabot-readable version comment.
if: ${{ success() && matrix.python_ver == '3.10' }}
uses: codecov/codecov-action@v4.6.0
with:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+41
to
+43
| - uses: actions/checkout@v4.4.0 | ||
| - name: Setup conda env | ||
| uses: mamba-org/setup-micromamba@v1 | ||
| uses: mamba-org/setup-micromamba@v1.11.0 |
Comment on lines
+42
to
+46
| - uses: actions/checkout@v4.4.0 | ||
| with: | ||
| lfs: true | ||
| - name: Setup conda env | ||
| uses: mamba-org/setup-micromamba@v1 | ||
| uses: mamba-org/setup-micromamba@v1.11.0 |
Comment on lines
+43
to
+47
| - uses: actions/checkout@v4.4.0 | ||
| with: | ||
| lfs: true | ||
| - name: Setup conda env | ||
| uses: mamba-org/setup-micromamba@v1 | ||
| uses: mamba-org/setup-micromamba@v1.11.0 |
| jobs: | ||
| call-workflow-pr_jira_actions: | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-jira-pr_actions.yml@v3 | ||
| uses: MiraGeoscience/CI-tools/.github/workflows/reusable-jira-pr_actions.yml@v3.9.1 |
Comment on lines
29
to
32
| fields: '{"components": [{"name": "geoapps"}]}' | ||
| - name: Post JIRA link | ||
| uses: peter-evans/create-or-update-comment@v4 | ||
| uses: peter-evans/create-or-update-comment@v4.0.0 | ||
| with: |
…voids Windows glob bug)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVOPS-1133 - pin all GitHub actions and reusable workflows to hash
Expands moving GitHub Actions tags to the full semver tag pointing at the same commit, then pins every
uses:to a commit hash with a dependabot-readable version comment.Tags expanded in this repo:
peter-evans/create-or-update-comment@v4 -> @v4.0.0MiraGeoscience/CI-tools/.github/workflows/reusable-jira-pr_actions.yml@v3 -> @v3.9.1actions/checkout@v4 -> @v4.4.0mamba-org/setup-micromamba@v1 -> @v1.11.0actions/checkout@v4 -> @v4.4.0mamba-org/setup-micromamba@v1 -> @v1.11.0codecov/codecov-action@v4 -> @v4.6.0actions/checkout@v4 -> @v4.4.0mamba-org/setup-micromamba@v1 -> @v1.11.0