Skip to content

GEOPY-2994: Support Grid2D in grid_model_merger application - #84

Merged
domfournier merged 4 commits into
developfrom
GEOPY-2994
Jul 29, 2026
Merged

GEOPY-2994: Support Grid2D in grid_model_merger application#84
domfournier merged 4 commits into
developfrom
GEOPY-2994

Conversation

@domfournier

@domfournier domfournier commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

GEOPY-2994 - Support Grid2D in grid_model_merger application

Copilot AI review requested due to automatic review settings July 28, 2026 22:28
@github-actions github-actions Bot changed the title GEOPY-2994 GEOPY-2994: Support Grid2D in grid_model_merger application Jul 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends grid_model_merger to better support Grid2D inputs by refining TreeMesh refinement logic for 2D meshes, tightening UI model type selection, and improving handling of “all NaN” model merges with a warning and a regression test.

Changes:

  • Add a warning/early-exit path when no valid model values are available during merge, plus a test asserting the warning.
  • Adjust refine_tree_by_mesh for Grid2D to derive refinement level from XY TreeMesh cell sizes (ignoring Z).
  • Restrict selectable input model data types in the UI JSON to Float only.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/run_tests/grid_model_merger_test.py Adds coverage for the “all NaN inputs” warning path.
grid_apps/utils.py Updates Grid2D TreeMesh refinement level calculation to use XY cell sizes.
grid_apps/grid_model_merger/driver.py Adds “no valid values” early return + guards inverse symlog by threshold.
grid_apps-assets/uijson/grid_model_merger.ui.json Restricts input model selection to float data types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread grid_apps/grid_model_merger/driver.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@domfournier
domfournier merged commit 5649695 into develop Jul 29, 2026
17 of 18 checks passed
@domfournier
domfournier deleted the GEOPY-2994 branch July 29, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants