GEOPY-3009: Pylint: Similar lines in tests (grid-apps) - #86
Merged
Conversation
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses GEOPY-3009 by reducing duplicated setup code in tests (to satisfy Pylint “similar lines”) by centralizing common grid/block-model creation logic in shared test helpers.
Changes:
- Moved repeated block-model and Grid2D setup code from individual tests into
tests/conftest.pyhelpers. - Updated block model tests to use the shared helper and adjusted assertions accordingly.
- Updated grid model merger test expectations to account for the new block-model setup behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
tests/run_tests/grid_model_merger_test.py |
Switched to shared grid setup helper; updated merge assertions accordingly. |
tests/run_tests/block_model_test.py |
Refactored tests to use shared block-model setup and updated padding/origin assertions. |
tests/conftest.py |
Added shared setup_block_model / setup_grid2d_model helpers for reuse across tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
benk-mira
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-3009 - Pylint: Similar lines in tests (grid-apps)