GEOPY-3019: Change in color array shape crashes conversion - #130
Open
domfournier wants to merge 3 commits into
Open
GEOPY-3019: Change in color array shape crashes conversion#130domfournier wants to merge 3 commits into
domfournier wants to merge 3 commits into
Conversation
github-actions
Bot
changed the title
There was a problem hiding this comment.
Pull request overview
Updates GeoH5 → OMF colormap/legend conversion to accommodate a changed color_map.values array orientation by transposing the source array before slicing RGB channels.
Changes:
- Transpose
entity_type.color_map.valueswhen buildingColorArraylegends for referenced/mapped data. - Transpose
entity_type.color_map.valueswhen rebuildingScalarColormap(limits + 128-step gradient) from GeoH5 entities.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benk-mira
requested changes
Jul 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #130 +/- ##
========================================
Coverage 92.78% 92.79%
========================================
Files 27 27
Lines 1525 1526 +1
========================================
+ Hits 1415 1416 +1
Misses 110 110
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-3019 - Change in color array shape crashes conversion