GEOPY-3011: Review logging and metric for tile size in Megabytes vs Mebibytes - #457
Open
domfournier wants to merge 5 commits into
Open
GEOPY-3011: Review logging and metric for tile size in Megabytes vs Mebibytes#457domfournier wants to merge 5 commits into
domfournier wants to merge 5 commits into
Conversation
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates output reporting and regression expectations, primarily to standardize how tile-size estimates are labeled/logged (bytes vs bits, SI vs IEC), and to align test baselines with current inversion behavior.
Changes:
- Standardized numeric formatting/targets in test utilities and updated multiple
target_runregression constants. - Updated tile size estimate labels from
GbtoGBin logs/plots (unit presentation). - Changed topography active-cell masking to use cell-bottom referencing for certain inversion types, updating downstream regression expectations.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/utils/targets.py |
Formats printed inversion metrics in scientific notation for more consistent output. |
tests/run_tests/driver_mt_test.py |
Updates regression target_run values to match current results. |
tests/run_tests/driver_joint_cross_gradient_test.py |
Updates regression target_run and expected scaling/multiplier arrays. |
tests/run_tests/driver_ip_test.py |
Updates regression target_run values. |
tests/run_tests/driver_ip_2d_test.py |
Updates regression target_run values. |
tests/run_tests/driver_dc_test.py |
Updates regression target_run values. |
tests/run_tests/driver_dc_2d_test.py |
Updates regression target_run values. |
tests/run_tests/driver_dc_2d_rotated_gradients_test.py |
Updates regression target_run values and relaxes tolerance for the check. |
simpeg_drivers/utils/tile_estimate.py |
Renames displayed units from Gb to GB in log output and plot labeling. |
simpeg_drivers/components/topography.py |
Alters active-cell selection behavior by switching the topography reference point for some inversion types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ax.set_xlabel("Number of tiles") | ||
| ax.set_aspect(tile_counts.max() / problem_sizes.max()) | ||
| ax.set_ylabel("Est. total size (Gb)") | ||
| ax.set_ylabel("Est. total size (GB)") |
Comment on lines
121
to
125
| active_cells = active_from_xyz( | ||
| mesh.entity, | ||
| vertices, | ||
| grid_reference="center", | ||
| grid_reference="bottom" if forced_to_surface else "center", | ||
| triangulation=cells, |
Comment on lines
+111
to
113
| # Estimate total size in GB | ||
| results[count] = float(sim.survey.nD) * mapping.shape[0] * count * 8 * 1e-9 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-3011 - Review logging and metric for tile size in Megabytes vs Mebibytes