Declare the scope of the tbigint arm of the tnumber/tbox nearest approach - #84
Merged
estebanzimanyi merged 1 commit intoAug 15, 2026
Conversation
…oach `nad_tint_tbox`, `nad_tbigint_tbox` and `nad_tfloat_tbox` share the wrapper `NAD_tnumber_tbox` and take a generic `const Temporal *`, so which of its three overloads each one serves cannot be read from MEOS: they all call the same `ensure_valid_tnumber_numspan`, which states the whole class. The int and float arms are declared for that reason; the big-integer arm arrived without one, so generation stops on it rather than guess. Declare it beside its two siblings. Deriving from MobilityDB d4d119c034 now completes, and `nad_tbigint_tbox` carries its own overload, `nearestApproachDistance(tbigint, tbox)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deriving the catalog from current MobilityDB master stops with
so no binding can regenerate until it is answered.
nad_tint_tbox,nad_tbigint_tboxandnad_tfloat_tboxall back the onewrapper
NAD_tnumber_tboxand all take a genericconst Temporal *, and eachvalidates with
ensure_valid_tnumber_numspan— a predicate for the wholenumber class. Nothing in MEOS says which of the wrapper's three overloads each
arm serves, which is why the int and float arms are already declared here. The
big-integer arm is new and arrived without one, so
require_scopesstops ratherthan take the union or nothing.
Declared beside its two siblings, with their wording.
Measured
Deriving from MobilityDB
d4d119c034:nad_tbigint_tboxnad_tbigint_tboxcarries exactly its own overload—
nearestApproachDistance(tbigint, tbox)— wherenad_tint_tboxkeeps(tint, tbox)andnad_tfloat_tboxkeeps(tfloat, tbox)Suite: 214 passed, 15 skipped. The two failures in
test_familyandtest_struct_layoutare pre-existing and unrelated — they reproduce on acatalog generated by master's parser from the same MobilityDB commit, and come
from parsing source-tree headers, whose PostgreSQL stubs degrade struct field
offsets to
-1; a--build-libmeoscatalog does not have them, which is why CIis green on them.