DEVOPS-3406 - add separate ingress templates for API and web services - #7
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Shared GKE annotations make both Ingress resources compete for the same static IP and ports.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Splits Den web and API routing into separate Kubernetes Ingress resources.
Changes:
- Removes API routing from the Den web Ingress.
- Adds a dedicated API Ingress template.
| File | Description |
|---|---|
ingress-den.yaml |
Retains only web routing. |
ingress-api.yaml |
Adds dedicated API routing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…Ps for web and API services
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The added Ingress breaks an existing CI resource-count assertion, and the GKE guide retains contradictory topology descriptions.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Public GCP instructions remain inconsistent, and the new Ingress behavior lacks meaningful render assertions.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (3)
| @@ -0,0 +1,33 @@ | |||
| {{- if and .Values.ingress.enabled .Values.ingress.api.enabled }} | |||
| web/API exposure, use two GKE Ingresses (one per host) with a shared | ||
| Google-managed certificate, one reserved global IP address per Ingress, and | ||
| explicit backend health checks. |
No description provided.