Fix SMBus constructor options type - #1688
Open
stc1988 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Yes, that makes sense. And it is consistent with how |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the SMBus constructor type declaration to use the first parameter of the I2C constructor.
ConstructorParameters produces a tuple containing the constructor arguments. Intersecting that tuple directly with the SMBus-specific options caused TypeScript to reject valid I2C properties such as address, data, clock, and hz.
Selecting the first tuple element with ConstructorParameters[0] correctly extends the I2C options with the optional SMBus stop property.