Stortini/msd updates

[matthewstortini]

Just adding field in reco data product for MSD channel ID, and a simple filter module.

[FNALbuild]

Hi @matthewstortini,
You have proposed changes to files in these packages:

• DAQ
• Trigger
• RecoDataProducts

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 8351b4e: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

[michaelmackenzie]

Looks good, thanks!

[FNALbuild]

☀️ The build tests passed at 8351b4e.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged 8351b4e at 3d84f93
build (prof)	✅	Log file. Build time: 04 min 21 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 3 files
clang-tidy	➡️	4 errors 11 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 8351b4e after being merged into the base branch at 3d84f93.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[oksuzian]

🔴 Blocking

1. _npass is never incremented → summary always reports 0 passes
In filter() you compute passed but never bump _npass, so endRun() always logs passed 0 events.

    passed &= naccepted >= _minHits;

    // Return the result
    return passed;

Add if(passed) ++_npass; before returning.

2. goodHit() ignores channelID — the whole point of the PR
The PR adds _channelID to MSDHit, but the filter only checks hasTime() and never uses the channel ID. Either filter on channel ID or clarify why it's unused.

  bool MSDHitFilter::goodHit(const MSDHit& hit) {
    if(!hit.hasTime()) return false; // time must be defined for the hit
    return true;
  }

🟡 Should fix

3. channelID has no hasChannelID() guard, unlike other fields
MSDHit defines hasTime()/hasTOT() but no hasChannelID(), despite using the same -1 sentinel. Add one for consistency.

  int _channelID{-1}; // channel ID

4. Author attribution mismatch — the module header credits "Michael MacKenzie, 2026" but the PR is by matthewstortini. Confirm this is intentional.

5. Trailing newline removed at the end of MSDHitsFromDTCEvents_module.cc (last hunk drops the final \n) — minor, but flags as a diff nit.

Notes / non-blocking

• minHits >= naccepted uses a count of accepted hits, but goodHit currently accepts nearly everything — behavior is effectively "at least N hits with a time."
• 2 conversation comments exist on the PR; no formal reviews yet.